fix: The project root is ambiguous in tsconfig.json#2127
Merged
dprevost-LMI merged 8 commits intoJun 29, 2026
Conversation
Contributor
Greptile SummaryThis PR resolves the
Confidence Score: 5/5Safe to merge — changes are scoped entirely to TypeScript configuration and test tooling with no runtime impact. The root fix (adding rootDir to tsconfig.build.json and moving outDir out of the base config) is correct and targeted. Switching the build to module/moduleResolution nodenext is intentional and appropriate for the ESM package. No logic, runtime, or API surface is changed. No files require special attention.
|
| Filename | Overview |
|---|---|
| tsconfig.build.json | Core fix: adds explicit rootDir, outDir, module/moduleResolution (nodenext), and tsBuildInfoFile; switches to include-based filtering — cleanly resolves the project root is ambiguous error. |
| tsconfig.json | Removes outDir (now only in tsconfig.build.json), adds mocks/**/*.ts to includes; minor style inconsistency (missing leading ./ on the mocks glob) but functionally correct. |
| vitest.config.ts | Coverage thresholds raised across all four metrics — straightforward update reflecting improved test coverage. |
| playgrounds/package-lock.json | Lock file updated to reflect a version bump from 5.6.8 to 5.7.0 for the parent package — no concerns. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[npm run build] --> B[compile:lib - tsc --build tsconfig.build.json]
A --> C[test:tsc - tsc --project tsconfig.json --noEmit]
B --> D[tsconfig.build.json]
D --> E[rootDir: ./src, outDir: ./lib/, module: nodenext]
E --> G[lib/ output]
C --> H[tsconfig.json - moduleResolution: bundler, no outDir]
H --> I[src + mocks + test included]
I --> J[type-check only, no emit]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[npm run build] --> B[compile:lib - tsc --build tsconfig.build.json]
A --> C[test:tsc - tsc --project tsconfig.json --noEmit]
B --> D[tsconfig.build.json]
D --> E[rootDir: ./src, outDir: ./lib/, module: nodenext]
E --> G[lib/ output]
C --> H[tsconfig.json - moduleResolution: bundler, no outDir]
H --> I[src + mocks + test included]
I --> J[type-check only, no emit]
Reviews (4): Last reviewed commit: "Rerun playgrounds + increase coverage" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The project root is ambiguous, but is required to resolve export map entry '.' in file '/Users/dprevost/Git/expect-webdriverio/package.json'. Supply the `rootDir` compiler option to disambiguate.ts
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
dprevost-LMI
force-pushed
the
fix-tsconfig-ambigious-root
branch
from
710d4d5 to
d53cce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the below error that sometimes also fails when executing
npm checks:all__mock__folder.